muntorg / munt-official

Munt is a witness-secured decentralized network for payments, digital assets, finance and more
https://www.munt.org
Other
135 stars 46 forks source link

Proper ISMINE_WITNESS behaviour #198

Open mjmacleod opened 4 years ago

mjmacleod commented 4 years ago

When we have only the witness key for a witness address and not the spending key, the codebase should behave differently.

The first part of this is already handled the various 'ismine' functions return ISMINE_WITNESS; however presently the rest of the codebase doesn't know how to deal with this and treats it as ISMINE_SPEND (aside from various UI components that treat things differntly at an account level, and a few RPC commands that know better.)

The rest of the codebase should be fixed to handle this correctly.

See: https://github.com/Gulden/gulden-official/commit/3c1381bebf6f0dafcc578fc4be8820b3150e617c