search

muntorg / munt-official

Munt is a witness-secured decentralized network for payments, digital assets, finance and more
https://www.munt.org
Other
135 stars 46 forks source link

Witness reward in estimated earnings must be 30 Gulden instead of 20 #208

Closed aat58 closed 4 years ago

aat58 commented 4 years ago

When a new witness account is made an estimated earning is presented to the customer. The calculation uses the old Witness reward of 20 Gulden instead of the new reward of 30 Gulden. So the earnings are to low calculated.

Besides that also the calculation uses the Total_network_weight_raw instead of the eligible_network_weight or the adjusted. I know it's probably done to give a worst-case value but the eligible weight and total weight are so widely spread that the calculated earnings are 40% lower than in reality.

Screenshots.

https://gyazo.com/c1c64afd91babed1c17f9da86e1542f8

Gulden version 2.2.0.7

Machine specs:

mjmacleod commented 4 years ago

You are correct that it uses the raw weight, which made sense when the code was initially written but should change now.

However I'm not sure why you think it is using the old reward (20); as far as I can tell it is using 30, is there something specific that makes you think otherwise?

aat58 commented 4 years ago

sorry i see my fault it's only the Total_network_weight_raw instead of the eligible_network_weight that gives the wrong reward calculation. :)