search

muntorg / munt-official

Munt is a witness-secured decentralized network for payments, digital assets, finance and more
https://www.munt.org
Other
135 stars 46 forks source link

Updated netrpc.cpp to return true on enablenetwork instead of false #214

Closed timkoers closed 4 years ago

timkoers commented 4 years ago

enablenetwork() returned false instead of true. Cleaned up the enable/disablenetwork return statements whilest at it

mjmacleod commented 4 years ago

enablenetwork change seems good.

Not entirely sure whether the disablenetwork change makes sense. With the change disablenetwork will return "true" when the network is enabled and "false" when the network is disabled - while (in my mind at least) the return value is meant to reflect whether the command succeeded or failed.

If the behaviour is instead going to be to return the state of network enabled/disabled then probably the help should at least document the return value to explain this

timkoers commented 4 years ago

That is correct! I've fixed the disablenetwork!