search

muodov / kociemba

A pure Python and pure C ports of Kociemba's algorithm for solving Rubik's cube
GNU General Public License v2.0
561 stars 126 forks source link

Add execute() method to CubieCube #10

Closed ansiwen closed 8 years ago

muodov commented 8 years ago

Hm, I might be wrong, but I think this execute() method won't be too helpful. I mean, CubieCube, FaceCube, and CoordCube are (currently) designed as internal structures for solving algorithm, and therefore they are not convenient for interactive programming. I guess execute() method would be interesting within some kind of a "human-friendly" API, which is not really present for now. Moreover, this usecase is much better covered by PyCuber.

So what do you think of adding this as a desired functionality for pycuber integration?

ansiwen commented 8 years ago

I had to write this function in order to test my solve to pattern stuff anyway. So I though you might be interested in it. Could be useful also for testing results. Btw.: If I'm not mistaken, the tests only test the C implementation, not the Python one, right?

muodov commented 8 years ago

Yeah, I'm planning to do a massive cleanup on the whole codebase later, and will add proper test suites for both implementations before that.