search

muodov / kociemba

A pure Python and pure C ports of Kociemba's algorithm for solving Rubik's cube
GNU General Public License v2.0
561 stars 126 forks source link

Change numeric chars to signed char for ARM compatibility #21

Closed ansiwen closed 8 years ago

ansiwen commented 8 years ago

On ARM char is 'unsigned char', not 'signed char'. Therefore numeric values have to use 'signed char' explicitly, otherwise functions like invCubieCube() are broken.

muodov commented 8 years ago

Hm, interesting. I was running it on Raspberry Pi without any problems, but I guess it was because invCubieCube() is not used during normal solving.

All looks good, but I think you forgot to change the toCubieCube() function (in facecube.c)

ansiwen commented 8 years ago

Right. Fixed.