muon-rw / Medieval-Origins-Revival

Origins inspired by mythology and the medieval era
https://legacy.curseforge.com/minecraft/mc-mods/medieval-origins-revival
1 stars 3 forks source link

[Incompatibility] RPG Difficulty causes Summoned Zombies to no longer spawn #62

Closed kyber-6 closed 2 months ago

kyber-6 commented 2 months ago

Issue regarding Revanant Origin as described by LastMarauder:

Hello, Muon! I'm afraid today's issue has been rather baffling so far.

The Revanant Origin seems to be having a problem. In just about every other way, it's in top shape, but when I'm in Solo on Fantasy MC, and I try to make a zombie...nothing! Everything else works fine, Skeletons, Zombie Horses, eating skulls, but not the base melee zombie!

We at Pixel Dream Studios have been working on including Medieval Origins into Fantasy MC, to see your works enjoyed by as many as possible! And would love to help, seeing as a number of fans are having the same issue. To assist, we've included a log of the instance occurring, and hope to provide aid in seeing the matter resolved.

Thank you for reading this! -The Pixel Dream Studios Team.

latest.log

muon-rw commented 2 months ago

Hi Kyber, looks like the issue is happening here: java.lang.IllegalArgumentException: Duplicate id value for 27! at net.minecraft.class_2945.method_12784(class_2945.java:81) ~[client-intermediary.jar:?] at dev.muon.medievalorigins.entity.SummonedZombie.method_5693(SummonedZombie.java:214) ~[medievalorigins-6.3.0+1.20.1.jar:?]

Which means I've done something really silly and probably easily fixable. Will take a look at this soon!

muon-rw commented 2 months ago

It looks to be a mod compat issue - maybe something else is assigning FOLLOW_RANGE automatically to all Zombies?

I'll try to narrow it down.

muon-rw commented 2 months ago

It's caused by this mixin.

Defining synched entity data in that mixin causes SummonedZombies' attempt to add a tracked Owner UUID result in this duplicate id value error.

Not really sure what to do about that, though...

muon-rw commented 2 months ago

Fixed in 6.3.1

KevzCz commented 2 months ago

Noice :Đ good work