search

muon-rw / Medieval-Origins-Revival

Origins inspired by mythology and the medieval era
https://legacy.curseforge.com/minecraft/mc-mods/medieval-origins-revival
2 stars 6 forks source link

High Elf Instant Cure #98

Closed yanalvesrj closed 3 months ago

yanalvesrj commented 3 months ago

High Elf Instant Cure is not working at the 1.20.1 a click with right buttom on Zombie NPC Villager with a Golden Apple and happens nothing.

muon-rw commented 3 months ago

Can you send a log with you attempting to use the power?

yanalvesrj commented 3 months ago

Sure! i'll send an video too. log-origins

yanalvesrj commented 3 months ago

https://github.com/muon-rw/Medieval-Origins-Revival/assets/69536502/180731c5-03c6-45a6-b636-0849e8379626

yanalvesrj commented 3 months ago

https://github.com/muon-rw/Medieval-Origins-Revival/assets/69536502/33cbee3c-5c66-47cd-a362-928fac7b754c

z-haopeng commented 3 months ago

Looking through the code, it seems like the High Elf origin just doesn't have the Instant Cure power listed. I made a dead simple PR (#103) that I think should fix it (tested by applying the change with a datapack).

muon-rw commented 3 months ago

Oh yeah, I removed it intentionally… I just forgot to remove the badge. Something else is planned!

yanalvesrj commented 3 months ago

Looking through the code, it seems like the High Elf origin just doesn't have the Instant Cure power listed. I made a dead simple PR (#103) that I think should fix it (tested by applying the change with a datapack).

I see! Thanks all! Now is just i create a origins.json in my datapack folder and paste that line to there?

muon-rw commented 3 months ago

If you want to use this with High Elf you can override /data/medievalorigins/origins/high_elf.json with a datapack - You'll also need to set a higher loading priority

yanalvesrj commented 3 months ago

If you want to use this with High Elf you can override /data/medievalorigins/origins/high_elf.json with a datapack - You'll also need to set a higher loading priority

I don't know how to do that LOL, i can't find my /data/medievalorigins/origins/high_elf.json

but i appreciate all help! Thanks a lot :)