various small improvements to tools

muon-spectroscopy-computational-project / muon-galaxy-tools

Tools for Muon Galaxy

2 stars 1 forks source link

various small improvements to tools #78

Closed bgruening closed 1 year ago

bgruening commented 2 years ago

[x] #89
[x] #90
[x] #91
[x] single quotes instead of double quotes for security reasons: https://github.com/muon-spectroscopy-computational-project/muon-galaxy-tools/blob/main/pm_dftb_opt_write/pm_dftb_opt_write.xml#L30
[x] #92
[x] #93
[x] #94

elichad commented 2 years ago

Thanks @bgruening, this is really helpful :)

patrick-austin commented 2 years ago

Sadly a lot of these links don't point to the line they used to or the file may have been moved/renamed. I think I've managed to work out what each was referring to, and to make this easier to track I've created new issues for these bullet points using GH permalinks. I'll leave this issue open, and once the new, specific issues have been addressed close this one too.

bgruening commented 2 years ago

@patrick-austin let me know if you need a hand. We have also some best practices guidelines here: https://galaxy-iuc-standards.readthedocs.io/en/latest/best_practices/tool_xml.html#tools