muon-spectroscopy-computational-project / training-material

A collection of Galaxy-related training material
https://training.galaxyproject.org
MIT License
0 stars 0 forks source link

Combine skeleton tutorials into materials science topic #4

Closed patrick-austin closed 7 months ago

patrick-austin commented 1 year ago

Combine the WIP tutorials for PyMuonSuite and MuSpinSim under one topic/subtopic.

Draft PR for internal review purposes, will need to make a PR against the upstream repo to actual merge and release these.

Suggestions for areas to add more content, scientific inaccuracies or general proofreading inaccuracies welcome.

patrick-austin commented 1 year ago

Thanks for the in depth review, there's clearly a lot typos and copy/pasting in errors here that you've caught. In terms of the weird pluralisation, Galaxy does this when you view a workflow: image I assume anything it just adds an s to the end of and arrays in the input. In principle I think these sections on the tools might be supposed to be auto generated from the workflow anyway, but I was modifying them manually based on Anish and Eli's old work. Either way I'll need to look into it and the other GTN bot's complaints some more.

patrick-austin commented 7 months ago

Made a few changes:

We've now got to the main stage of the CI, which is comments on the actual tutorial rather than the metadata level. These are fairly descriptive so hopefully can resolve them.