Closed patrick-austin closed 7 months ago
Thanks for the in depth review, there's clearly a lot typos and copy/pasting in errors here that you've caught. In terms of the weird pluralisation, Galaxy does this when you view a workflow:
I assume anything it just adds an s
to the end of and arrays in the input. In principle I think these sections on the tools might be supposed to be auto generated from the workflow anyway, but I was modifying them manually based on Anish and Eli's old work. Either way I'll need to look into it and the other GTN bot's complaints some more.
Made a few changes:
main
maintainers
(editorial_board
replaced this sometime in the last year - @leandro-liborio added this block but the old syntax was still there causing issues)time_estimate
back in as apparently it's required/
s and removed the instance url from the tool ids. This is in line with what the other tutorials seem to do, so hopefully will work. More generally, the tutorial seems to check "public" instances for these tools. Don't know if materials.usegalaxy.eu will show up there or just usegalaxy.eu, as the public-server-tools.json
file doesn't seem to be in the source code?We've now got to the main stage of the CI, which is comments on the actual tutorial rather than the metadata level. These are fairly descriptive so hopefully can resolve them.
Combine the WIP tutorials for PyMuonSuite and MuSpinSim under one topic/subtopic.
Draft PR for internal review purposes, will need to make a PR against the upstream repo to actual merge and release these.
Suggestions for areas to add more content, scientific inaccuracies or general proofreading inaccuracies welcome.