search

muonw / muonw-powertable

▦ PowerTable is a Svelte component that turns JSON data into an interactive HTML table. Inspired by DataTables. Powered by Svelte.
https://muonw.github.io/muonw-powertable/
Other
218 stars 13 forks source link

[Improvement] Remove empty filters on remote data query #13

Closed TheArcaneBrony closed 1 year ago

TheArcaneBrony commented 1 year ago

Currently, all empty filters are passed as remote parameters. This seems oddly pointless. Would it be reasonable to filter these before calling dataFeed? Evaluating these would inevitably make no difference on the end result anyways...

muonw-public commented 1 year ago

Filtering out the empty values before calling the API sounds like a good idea. The expectation is to have access to unaltered objects in dataFeed, but they can be customized by user (inside the user-defined dataFeed function) before calling the API.