search

mupchrch / outline-selection

Outline selections with a custom border in the Atom text editor.
MIT License
2 stars 0 forks source link

Proposal: Border radius #10

Closed KSXGitHub closed 8 years ago

KSXGitHub commented 8 years ago

I want to create a pull request but your package is written solely in JavaScript so I don't know how to make it 😄

Anyway, I already found a solution, this is my styles.less

atom-text-editor, atom-text-editor::shadow {
  @border-radius: @outline-selection-border-radius;
  .outline-selection {
    .outline-selection-left {
      border-top-left-radius: @border-radius;
      border-bottom-left-radius: @border-radius;
    }
    .outline-selection-top {
      border-top-left-radius: @border-radius;
      border-top-right-radius: @border-radius;
    }
    .outline-selection-right {
      border-top-right-radius: @border-radius;
      border-bottom-right-radius: @border-radius;
    }
    .outline-selection-bottom {
      border-bottom-left-radius: @border-radius;
      border-bottom-right-radius: @border-radius;
    }
  }
}

And this is the result image

mupchrch commented 8 years ago

That looks awesome! I think this would be a really cool setting to have in the menu, great idea!

KSXGitHub commented 8 years ago

Thanks! When you release new version which contains this enhancement, please let me know so I can remove that styles.less hack.

mupchrch commented 8 years ago

@KSXGitHub You should have an update available!

KSXGitHub commented 8 years ago

Great, thanks!