search

mupchrch / outline-selection

Outline selections with a custom border in the Atom text editor.
MIT License
2 stars 0 forks source link

Error when cmd+click inside selection #8

Closed mupchrch closed 8 years ago

mupchrch commented 8 years ago

[Enter steps to reproduce below:]

  1. Select some text
  2. cmd+click inside the selection

Atom Version: 1.8.0 System: Mac OS X 10.10.5 Thrown From: outline-selection package, v0.2.2

Stack Trace

Uncaught TypeError: Cannot read property 'destroy' of undefined

At /Users/upchm/github/outline-selection/lib/outline-selection.js:47

TypeError: Cannot read property 'destroy' of undefined
    at /Users/upchm/github/outline-selection/lib/outline-selection.js:47:26
    at Function.module.exports.Emitter.simpleDispatch (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
    at Emitter.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:125:28)
    at TextEditor.module.exports.TextEditor.removeSelection (/Applications/Atom.app/Contents/Resources/app.asar/src/text-editor.js:2283:27)
    at Selection.module.exports.Selection.markerDidDestroy (/Applications/Atom.app/Contents/Resources/app.asar/src/selection.js:945:19)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/selection.js:46:24
    at Function.module.exports.Emitter.simpleDispatch (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
    at Emitter.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:125:28)
    at TextEditorMarker.module.exports.TextEditorMarker.destroyed (/Applications/Atom.app/Contents/Resources/app.asar/src/text-editor-marker.js:229:20)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/text-editor-marker.js:37:24
    at Function.module.exports.Emitter.simpleDispatch (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
    at Emitter.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:125:28)
    at Marker.module.exports.Marker.destroy (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/text-buffer/lib/marker.js:252:27)
    at TextEditorMarker.module.exports.TextEditorMarker.destroy (/Applications/Atom.app/Contents/Resources/app.asar/src/text-editor-marker.js:43:25)
    at Selection.module.exports.Selection.destroy (/Applications/Atom.app/Contents/Resources/app.asar/src/selection.js:52:26)
    at Selection.module.exports.Selection.merge (/Applications/Atom.app/Contents/Resources/app.asar/src/selection.js:893:29)
    at reducer (/Applications/Atom.app/Contents/Resources/app.asar/src/text-editor.js:2231:29)
    at Array.reduce (native)
    at Object._.reduce._.foldl._.inject (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/underscore-plus/node_modules/underscore/underscore.js:114:28)
    at TextEditor.module.exports.TextEditor.mergeSelections (/Applications/Atom.app/Contents/Resources/app.asar/src/text-editor.js:2238:9)
    at TextEditor.module.exports.TextEditor.mergeIntersectingSelections (/Applications/Atom.app/Contents/Resources/app.asar/src/text-editor.js:2186:35)
    at TextEditor.module.exports.TextEditor.addSelection (/Applications/Atom.app/Contents/Resources/app.asar/src/text-editor.js:2261:12)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/text-editor-marker-layer.js:109:18
    at Function.module.exports.Emitter.simpleDispatch (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
    at Emitter.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:125:28)
    at MarkerLayer.module.exports.MarkerLayer.createMarker (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/text-buffer/lib/marker-layer.js:388:22)
    at MarkerLayer.module.exports.MarkerLayer.markRange (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/text-buffer/lib/marker-layer.js:193:19)
    at MarkerLayer.module.exports.MarkerLayer.markPosition (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/text-buffer/lib/marker-layer.js:204:19)
    at TextEditorMarkerLayer.module.exports.TextEditorMarkerLayer.markBufferPosition (/Applications/Atom.app/Contents/Resources/app.asar/src/text-editor-marker-layer.js:88:52)
    at TextEditorMarkerLayer.module.exports.TextEditorMarkerLayer.markScreenPosition (/Applications/Atom.app/Contents/Resources/app.asar/src/text-editor-marker-layer.js:94:19)
    at TextEditor.module.exports.TextEditor.addCursorAtScreenPosition (/Applications/Atom.app/Contents/Resources/app.asar/src/text-editor.js:1573:34)
    at TextEditorComponent.module.exports.TextEditorComponent.onMouseDown (/Applications/Atom.app/Contents/Resources/app.asar/src/text-editor-component.js:752:27)
    at HTMLDivElement.<anonymous> (/Applications/Atom.app/Contents/Resources/app.asar/src/text-editor-component.js:3:61)

Commands

     -2:58.4.0 core:move-right (atom-text-editor.editor.power-mode.is-focused)
  2x -2:58.1.0 core:move-left (atom-text-editor.editor.power-mode.is-focused)
     -2:49.7.0 core:save (atom-text-editor.editor.power-mode.is-focused.autocomplete-active)
  8x -2:36.8.0 core:backspace (atom-text-editor.editor.power-mode.is-focused.autocomplete-active)
     -2:29.7.0 core:move-right (atom-text-editor.editor.power-mode.is-focused)
     -2:26.7.0 core:save (atom-text-editor.editor.power-mode.is-focused)
  2x -2:08.5.0 core:backspace (atom-text-editor.editor.power-mode.is-focused)
     -1:57.9.0 core:save (atom-text-editor.editor.power-mode.is-focused)
  3x -1:14 core:backspace (atom-text-editor.editor.power-mode.is-focused)
     -1:10.4.0 core:save (atom-text-editor.editor.power-mode.is-focused)
     -1:03.4.0 core:copy (atom-text-editor.editor.power-mode.is-focused)
     -1:01.7.0 docblockr:parse-enter (atom-text-editor.editor.power-mode.is-focused)
     -1:01.7.0 editor:newline (atom-text-editor.editor.power-mode.is-focused)
     -1:01.6.0 core:paste (atom-text-editor.editor.power-mode.is-focused)
  3x -0:58.5.0 core:backspace (atom-text-editor.editor.power-mode.is-focused)
  2x -0:57.2.0 core:save (atom-text-editor.editor.power-mode.is-focused)

Config

{
  "core": {
    "allowPendingPaneItems": false,
    "openEmptyEditorOnStart": false,
    "packagesWithKeymapsDisabled": [
      "activate-power-mode"
    ],
    "themes": [
      "atom-material-ui",
      "firewatch-syntax"
    ]
  },
  "outline-selection": {
    "outlineColor": {
      "red": 82,
      "green": 178,
      "blue": 184,
      "alpha": 1
    },
    "outlineOpacity": 0.4,
    "outlineWidth": 2
  }
}

Installed Packages

# User
activate-power-mode, v0.5.2
atom-beautify, v0.29.8
atom-material-ui, v1.2.13
atom-synergy, v0.0.32
atom-typescript, v8.11.0
docblockr, v0.7.3
file-icons, v1.7.14
firewatch-syntax, v1.0.1
flex-tool-bar, v0.10.2
glowing-cursor, v0.1.1
highlight-selected, v0.11.2
linter, v1.11.10
minimap, v4.24.6
minimap-find-and-replace, v4.5.1
minimap-highlight-selected, v4.4.0
minimap-linter, v1.1.1
minimap-selection, v4.4.0
minimap-split-diff, v0.3.1
outline-selection, v0.2.2
pigments, v0.29.2
tool-bar, v0.4.0
tree-view-filter, v0.4.1
upchm, vundefined

# Dev
No dev packages