search

mupchrch / split-diff

Side-by-side file compare for the Atom text editor.
https://atom.io/packages/split-diff
MIT License
200 stars 26 forks source link

Syntax highlighting broken #141

Closed WilliamNurmi closed 6 years ago

WilliamNurmi commented 6 years ago

Recently, split-diff's syntax highlighting has broken for me. Split-diff has been working flawlessly so far, but suddenly I'm having no syntax highlighting on the original-side (see below). Restart, changing package settings, or Atom (syntax) themes does not fix the issue. Any idea what's wrong here?

split-diff 1.5.2 Atom 1.24.0 (theme: Atom Dark, syntax theme: Base16 Tomorrow Dark) macOS 10.13.3

screen shot 2018-02-19 at 9 57 55
ZenekeZene commented 6 years ago

+1

ChenXiyu commented 6 years ago

Is the root cause of this issue similar with https://github.com/akonwi/git-plus/issues/717 ?

mupchrch commented 6 years ago

TextEditor.setGrammar and TextEditor.getGrammar functions were deprecated due to the changes in https://github.com/atom/atom/pull/16087. Updated to use these new language mode APIs.

igor10k commented 6 years ago

@mupchrch why wasn't this fix ever released?

mupchrch commented 6 years ago

@Igor10k That is a great question... Publishing this patch now!

mizmaar3 commented 6 years ago

@mupchrch its back again in Atom 1.32.1 unfortunately