search

mupchrch / split-diff

Side-by-side file compare for the Atom text editor.
https://atom.io/packages/split-diff
MIT License
200 stars 26 forks source link

Syntax highlighting broken in Atom 1.32.1 #153

Closed mizmaar3 closed 5 years ago

mizmaar3 commented 5 years ago

Same like: https://github.com/mupchrch/split-diff/issues/141?_pjax=%23js-repo-pjax-container

but in latest Atom ver 1.32.1

waldnzwrld commented 5 years ago

I found that using split diff:enable and split diff:disable shows the correct highlighting. It's only when using split diff:toggle that I lose syntax highlighting. Also once untoggled syntax highlighting is broken for the primary file (original not compared) until I set the syntax again.

mupchrch commented 5 years ago

@mizmaar3 @waldnzwrld I believe this might be fixed by #157. I've just released a new version of the package, let me know if it fixes this issue and we can close this out, thanks!

waldnzwrld commented 5 years ago

Yup!! Everything is toggling the way it should!!! Thanks @mupchrch !!

mupchrch commented 5 years ago

Pass along the thanks to @hSaria :)