search

mupen64plus / mupen64plus-core

Core module of the Mupen64Plus project
1.25k stars 254 forks source link

RSP opcode fixes #1061

Closed GhostlyDark closed 2 months ago

GhostlyDark commented 5 months ago

Ported from: https://gitlab.com/parallel-launcher/parallel-n64/-/commit/4f7b8a6081f7d02bac26e041f1baf5d5e91875f2 https://gitlab.com/parallel-launcher/parallel-n64/-/commit/3052f79c162a232301fdf725038f813c1ec02edb https://gitlab.com/parallel-launcher/parallel-n64/-/commit/f379d606e4dd000b72ae90273a1b1874b51f5307 https://gitlab.com/parallel-launcher/parallel-n64/-/commit/07ce4bfd7528cde68939ad2ce1a06c2c7029ec15#06a9a5c035040370b6d9d811526d9586179b3176_52_52

Reference: https://github.com/libretro/parallel-rsp/pull/10

GhostlyDark commented 5 months ago

@mpharoah Anything missing here?

mpharoah commented 5 months ago

Looks good

Narann commented 2 months ago

Thanks all for your work and the reviews. This looks good to me. Can I merge ?

GhostlyDark commented 2 months ago

It can be merged, it shouldn't cause any regressions. I should mention however that there are follow-up changes that aren't as straightforward to port over, but those could be part of another PR. https://github.com/Rosalie241/RMG/issues/242#issuecomment-2023945572 https://gitlab.com/parallel-launcher/parallel-n64/-/compare/d15b5a3a2ec7a9451ef01c3b278c196e6031f3b1...f2f72c2efdac810a198f901fccf04798ef96d9e1?from_project_id=34649479&straight=false

Narann commented 2 months ago

Thanks ! I also agree about putting those in a separated PR.