search

mupen64plus / mupen64plus-core

Core module of the Mupen64Plus project
1.32k stars 258 forks source link

Banjo-Tooie: Music goes silent in Jolly Roger Lagoon (ParaLLEl RDP) #1069

Open 03bgood opened 7 months ago

03bgood commented 7 months ago

In Jolly Roger Lagoon, if you warp from "Big Fish Cavern" or "Locker's Cavern" back to "Town Center", the music goes completely silent until you go through a loading zone (i.e. Jolly's Bar). This doesn't happen at all with "GLideN64" and the music plays fine when warping from those two aforementioned locations. Oddly enough, warping from "Atlantis" won't trigger the music stopping glitch, so what's going on?

A similar glitch like this also occurs in Donkey Kong 64 during a bonus challenge after the introduction music plays and the timer starts, the actual bonus stage music doesn't play or eventually starts after about 10-15 seconds.

Jj0YzL5nvJ commented 7 months ago

RDP can influence the audio of very few games, and none of the ones you mention are one of them. The most likely culprit could be the RSP.

Try to reproduce the issues with GLideN64 + ParaLLEl RSP and ParaLLEl RDP + CXD4 RSP.

03bgood commented 7 months ago

RDP can influence the audio of very few games, and none of the ones you mention are one of them. The most likely culprit could be the RSP.

Try to reproduce the issues with GLideN64 + ParaLLEl RSP and ParaLLEl RDP + CXD4 RSP.

It's definitely "ParaLLEl RDP" because changing it to "GLideN64" fixes the music issue.

Jj0YzL5nvJ commented 7 months ago

Can you reproduce said issue on RMG?

03bgood commented 7 months ago

Can you reproduce said issue on RMG?

I'm actually using the RetroArch core. I'm running RA via the Steam Deck.

Jj0YzL5nvJ commented 7 months ago

Current versions of Mupen64Plus-Next have regressions in ParaLLEl RSP.

The hotfix has not yet been integrated into Mupen64Plus-Next, the regression also affects RMG v0.5.8. RMG v0.5.7 should work correctly.

03bgood commented 7 months ago

Current versions of Mupen64Plus-Next have regressions in ParaLLEl RSP.

The hotfix has not yet been integrated into Mupen64Plus-Next, the regression also affects RMG v0.5.8. RMG v0.5.7 should work correctly.

So, is a fix planned for the RA core?

Jj0YzL5nvJ commented 7 months ago

This repository is upstream and has no direct relationship with the Libretro cores. The "fix" will come, but I don't know when. In upstream, the workaround is to use an older version of the problematic component or patch the newer one. Libretro already has a patch, but it's not applied.

A proper solution will take some time to arrive... if you want to force Libretro to use the existing solution, you just have to let them know that Banjo-Tooie is not the only game affected by the regression and they will have more motivations to fix it.

Go ahead: libretro/parallel-rsp#12

m4xw commented 7 months ago

This repository is upstream and has no direct relationship with the Libretro cores. The "fix" will come, but I don't know when. In upstream, the workaround is to use an older version of the problematic component or patch the newer one. Libretro already has a patch, but it's not applied.

A proper solution will take some time to arrive... if you want to force Libretro to use the existing solution, you just have to let them know that Banjo-Tooie is not the only game affected by the regression and they will have more motivations to fix it.

Go ahead: libretro/parallel-rsp#12

this is not related at all, nx uses RSP on a commit before the accuracy fixes and before the regresion, i didnt roll it out yet

Jj0YzL5nvJ commented 7 months ago

this is not related at all, nx uses RSP on a commit before the accuracy fixes and before the regresion, i didnt roll it out yet

Whoops, sorry. I didn't check the hashes and somehow I mixed up the dates... I need more sleep.

I haven't used RA in years, is there a way to use GLideN64 in LLE mode with ParaLLEl RSP? According to me it was possible, but perhaps my memory is betraying me.

03bgood commented 7 months ago

this is not related at all, nx uses RSP on a commit before the accuracy fixes and before the regresion, i didnt roll it out yet

Whoops, sorry. I didn't check the hashes and somehow I mixed up the dates... I need more sleep.

I haven't used RA in years, is there a way to use GLideN64 in LLE mode with ParaLLEl RSP? According to me it was possible, but perhaps my memory is betraying me.

GLIdeN64 is a very buggy mess with some games! I just want the music issues fixed and maybe the minor framerate issues as well. The music glitches out in some places like JRL. The music even glitches out after winning or losing a mini game where all variations of a level theme will all play at once. This happens in almost all levels. There's a glitch in Hailfire Peaks where when you sometimes leave the colloseum, the crowd noise won't go away, even when you're far enough away from the building. No idea why games like B-T and DK64 have music issues when running ParaLLEl RDP.

Also, apparently sometimes warping from "Atlantis" to "Town Center" in JRL does indeed make the music go silent, so I really hope this music issue with B-T is fixed ASAP! Pausing does bring the music back, but it plays all variations of JRL, which as mentioned above, also occurs in almost every level when beating some mini-games. It's really quite annoying.