search

mupen64plus / mupen64plus-core

Core module of the Mupen64Plus project
1.25k stars 254 forks source link

Update minizip #1074

Closed loganmc10 closed 1 month ago

loganmc10 commented 2 months ago

Minizip no longers builds for me in the latest versions of GCC

/__w/simple64/simple64/mupen64plus-core/subprojects/minizip/zip.c:1249:28: error: assignment to 'const long unsigned int *' from incompatible pointer type 'const uint32_t *' {aka 'const unsigned int *'} [-Wincompatible-pointer-types]
 1249 |         zi->ci.pcrc_32_tab = get_crc_table();

I've updated minizip using the latest sources from here: https://github.com/madler/zlib/tree/master/contrib/minizip

Jj0YzL5nvJ commented 2 months ago

I think it's worth mentioning the potential vulnerability this fixes: madler/zlib#868 Personally I was waiting for 1.3.2...

Note: MSYS2 is currently failing due to the missing vulkan-headers dependencies, I will send an upgrade for CI/CD soon...