mupen64plus / mupen64plus-core

Core module of the Mupen64Plus project
1.25k stars 254 forks source link

Missing bounds checks on DMA operations #1083

Open mpharoah opened 3 weeks ago

mpharoah commented 3 weeks ago

In this commit, there was a fix for an overflow in RSP DMAs, but none of the other missing bounds checks were fixed.

Here is a pull request that fixes all the DMAs in ParallelN64.

The mupen core has since moved around and refactored most of these places, so some of them may already be fixed; however, I can find some locations where vulnerabilities still exist:

There may be some other locations as well