mupen64plus / mupen64plus-core

Core module of the Mupen64Plus project
1.32k stars 258 forks source link

Backport mupen64plus-libretro-nx dynarec fix for OoTMM randomizer #1086

Closed alice-mkh closed 4 months ago

alice-mkh commented 4 months ago

So, currently https://ootmm.com/ works with said libretro core but crashes when transitioning between games with upstream m64p. I narrowed it down to this commit: https://github.com/libretro/mupen64plus-libretro-nx/commit/9cbe0fedf18ee13874ac3361ad013c41806fe4c7

With this change I can confirm it switches without crashes:

Screencast from 2024-07-05 18-26-14.webm

Disclaimer: I don't know if it makes sense, this is their commit unchanged (except for code style fixes)

m4xw commented 4 months ago

Been wanting to upstream that for ages but @Gillou68310 wanted that to work for all interpreter types too and we never verified that

alice-mkh commented 4 months ago

Ah, that is fair. I don't have the knowledge to do that myself, but at least it's documented now, as I previously tried to find it and there was nothing at all ^^

m4xw commented 4 months ago

I did it originally for @LuigiBlood 's DD shenanigans