search

mupen64plus / mupen64plus-core

Core module of the Mupen64Plus project
1.25k stars 255 forks source link

Fix screenshots when compiling with OSD=0 #992

Closed Rosalie241 closed 1 year ago

Rosalie241 commented 1 year ago

When compiling with OSD=0, OnScreenDisplay is True in the configuration file and video_plugin_render_callback is called with 0, then taking a screenshot will fail.

This patch fixes that issue, I do wonder if I should extend this patch to guard every OSD function call with a #ifdef M64P_OSD to prevent it having to access the OnScreenDisplay option in the configuration file?

Narann commented 1 year ago

I would have manage to remove the use of bOSD everywhere so you have no dead code when compiling with OSD=0.

Rosalie241 commented 1 year ago

I would have manage to remove the use of bOSD everywhere so you have no dead code when compiling with OSD=0.

Fixed