mupen64plus / mupen64plus-core

Core module of the Mupen64Plus project
1.25k stars 255 forks source link

Sanitize save filename #993

Closed Rosalie241 closed 1 year ago

Rosalie241 commented 1 year ago

This patch fixes an issue where i.e on windows, certain characters like :<>"/\|?* aren't allowed to be used for filenames, causing mupen64plus to be unable to create a save, this issue mainly occurs when a ROM/ROM hack isn't in the database and it uses the internal ROM name for the filename, I could make this patch windows-only mostly but to make the filenames consistent across platforms I think it makes sense to do it for all platforms.

Narann commented 1 year ago

LGTM.