Wrong special characters are used

mupen64plus / mupen64plus-ui-console

Console (command-line) front-end user interface for Mupen64Plus v2.0 project

46 stars 68 forks source link

Wrong special characters are used #71

Open Jj0YzL5nvJ opened 3 years ago

Jj0YzL5nvJ commented 3 years ago

test_cp1252.zip

Narann commented 3 years ago

I'm not sure it's a mupen bug. What happen if you open a terminal in the problematic folder?

Jj0YzL5nvJ commented 3 years ago

https://imgur.com/a/zyP38QL https://imgur.com/a/5RFNy85

Jj0YzL5nvJ commented 3 years ago

It appears that an unnecessary string conversion is being performed. https://imgur.com/a/OtmpuZY

mupen64plus/mupen64plus-core#688 loganmc10/m64p#157

Edit: Sorry, I packed the wrong text file (test2.txt vs hmm.txt). Fixed - test2.zip

loganmc10 commented 3 years ago

I don't think mupen64plus-core really supports Unicode/UTF-8 on Windows.

mupen64plus-core uses fopen (and similar functions). This works for UTF-8 on Linux, however on Windows you need to use _wfopen and pass it a wchar_t/UTF-16 string.

Those functions should be brought into "osal" and have separate implementations for Windows and Linux.