mupen64plus / mupen64plus-ui-python

A frontend for Mupen64Plus
http://m64py.sourceforge.net/
GNU General Public License v3.0
247 stars 67 forks source link

Fixes/open rom from list #201

Closed nathan-chappell closed 2 years ago

nathan-chappell commented 2 years ago

The "open rom from list" functionality wasn't working for me. In particular, it wasn't listing any roms. I updated the code to add roms to the list by searching the indicated rom directory recursively using pathlib.Path.rglob, and also made changes so roms would be added to the list even if the call to core.get_rom_settings returns None due to an error in the underlying core call. It seems this is only used to get some useful name for the game, so in the event it's not found we just add it to the list anyways.

I also noticed that the defs was out of date, so I updated it.

gen2brain commented 2 years ago

The updated fields from m64p_rom_settings are not released yet, have you checked against master? When there is a new mupen64plus I will update it, not before, it will just break for many users that use distro packages. There are also changes for vidext number of functions, other definitions, etc.

Also, I believe you are using the latest mupen64plus build from master? That is why romlist doesn't work. I do have some local changes but again, will merge them when there is a new release. Not sure about recursive also, I prefer to list ROMs from one directory, usually all ROMs are in a single dir, not scattered through many directories?

nathan-chappell commented 2 years ago

Sounds like you got it all figured out, I'll delete my pull request.

gen2brain commented 2 years ago

Sorry, I should probably create a new branch with code that works with the current mupen64plus master, I just don't have time for that. If I add that here, there will be a bunch of new issues, if I don't, again there are problems. When new mupen64plus is released it will be somewhat easier.

nathan-chappell commented 2 years ago

Understood. If you ever decide to make a "to do list" or "contributing" section and you need help, feel free to send a message.

gen2brain commented 2 weeks ago

Code is now updated for the latest mupen64plus, migrated to Qt6, Wayland is supported, bugs are fixed, etc. I will release a new version these days.