search

mupen64plus / mupen64plus-video-glide64mk2

Video plugin for Mupen64Plus 2.0 based on 10th anniversary release code from gonetz
28 stars 37 forks source link

Fixes and enhancements from mupen64plus-ae #39

Closed littleguy77 closed 9 years ago

littleguy77 commented 9 years ago

@Gillou68310 Please let me know if I have misattributed anything or my explanations are not clear. Thanks :)

richard42 commented 9 years ago

You could change the pixel array to 2048 * 2048 * 2 instead of *4, since you are reading bytes, and each pixel is 4 bytes, or 2 shorts.

Gillou68310 commented 9 years ago

That's definitely the best solution ;-) Just for information glReadPixels is storing in contiguous memory when using GL_RGBA that's why we can do that.

littleguy77 commented 9 years ago

Thanks for the quick feedback. I'll make the recommended changes, add some documentation in the comments, and reopen the pull request when it's ready.

littleguy77 commented 9 years ago

Thanks for the suggestions. Made the fixes and reopened the PR.

richard42 commented 9 years ago

I would recommend removing the logging change, since it causes a performance issue.

littleguy77 commented 9 years ago

The change actually improves performance, but I can remove it if you wish.

littleguy77 commented 9 years ago

Ok, I removed the last commit.

littleguy77 commented 9 years ago

@richard42 Just occurred to me I might have misread your last comment. Which commit did you want me to remove?

https://github.com/littleguy77/mupen64plus-video-glide64mk2/commit/90601dbb94d501c6c84a9ab355fa244b1ebb1c29

https://github.com/littleguy77/mupen64plus-video-glide64mk2/commit/68fd85740119821b14795ad9ec012dd811cb035d