mupen64plus / mupen64plus-video-glide64mk2

Video plugin for Mupen64Plus 2.0 based on 10th anniversary release code from gonetz
28 stars 37 forks source link

Add missing file from GLES port and minor cleanup #42

Closed littleguy77 closed 9 years ago

littleguy77 commented 9 years ago

Pull request #12 accidentally omitted OGLESwrappers.h (formerly named glState.cpp in mupen64plus-ae). I assume it went unnoticed because the project builds and runs without it. The wrappers ensure that the vertex buffer is drawn before certain changes to the GL state. Without this file, some vertices will be incorrectly shaded/offset/clipped etc., because the GL state at buffer-time differs from the GL state at draw-time. The GL codepath has no such concerns because it uses immediate mode rather than vertex buffers, where the provision and drawing of vertices happens concurrently.

The DK64 launch intro/rap scene is an easy place to see what this fixes under GLES. Without this fix, the transition after the Dolby logo displays artifacts, and the captions during the rap scene are missing some letters/words.

On another note, #12 should have been attributed to @Metricity and I'm sorry that I overlooked that. At least there's a reference to the Android project should someone want to study the history of his port.