search

mupen64plus / mupen64plus-video-glide64mk2

Video plugin for Mupen64Plus 2.0 based on 10th anniversary release code from gonetz
28 stars 37 forks source link

Avoid overlapping memcpy(). #49

Closed bentley closed 9 years ago

bentley commented 9 years ago

Per the standard, memcpy()’s behavior on overlapping buffers is undefined. On OpenBSD, an overlapping memcpy triggers a crash here. Use memmove() instead, as its behavior on overlapping buffers is well defined.

Narann commented 9 years ago

Seems fine. I have no idea about performance impact.