search

mupen64plus / mupen64plus-video-glide64mk2

Video plugin for Mupen64Plus 2.0 based on 10th anniversary release code from gonetz
28 stars 37 forks source link

change the way OPTFLAGS is initialized #55

Closed krnlyng closed 9 years ago

krnlyng commented 9 years ago

change the way OPTFLAGS is initialized so build scripts can actually overwrite the full OPTFLAGS variable

i came across an issue with gcc version 4.6.3 (see https://code.google.com/p/mupen64plus/issues/detail?id=559) and the solution was to not specify -flto in OPTFLAGS but i couldn't do that from the build script because the Makefile adds -flto=jobserver to OPTFLAGS when built on linux. i hope this is not a too horrible workaround, another option would be to check for the gcc version in the makefile but i think this is the nicer solution

ghost commented 9 years ago

Just revert 5d3bc01510a24fbecbc5f59df1c1dbd8ef9bfa52 and 79f34ce5603a2c4dfe0c3e669191a0058dcd3bdd (it was a bad idea because this was the reason why @richard42 started to add the bad hack)

Just make sure e941f7fd8f68856d1f58179c4f880556475b04de stays in.

krnlyng commented 9 years ago

@richard42 this would be one alternative, if linking speed matters...

richard42 commented 9 years ago

yeah I don't really care about the linking speed that much.