search

mupen64plus / mupen64plus-video-rice

Video plugin for the Mupen64Plus v2.0 project, using OpenGL. This plugin is based on the RiceVideoLinux plugin from earlier versions of Mupen64Plus.
31 stars 40 forks source link

Regression in Zelda OOT when using GLES #24

Closed Gillou68310 closed 9 years ago

Gillou68310 commented 9 years ago

zelda_collision_mesh

This has been introduced by commit https://github.com/mupen64plus/mupen64plus-video-rice/commit/e9ef968bd5961181099072b710e1c200f88106f6

@krnlyng

krnlyng commented 9 years ago

@Gillou68310 hmm i cannot reproduce it here

Gillou68310 commented 9 years ago

Which device are you testing on? This is happening to me on both real hardware (Galaxy note 3) and PowerVR GLES emulator.

krnlyng commented 9 years ago

@Gillou68310 both Desktop and the Jolla Phone, i could also try and see if it happens on my n9, if i can locate it

EDIT: i had something similar when i was trying out glide64mk2 for the first time on my phone, as can be seen in my video: https://www.youtube.com/watch?v=zrMkrFUClmc but that disappeared after a "make clean" for some reason

Gillou68310 commented 9 years ago

that's weird!

Also it seems like not everything is being rotated, look at the blue action icon: zelda_rotate

krnlyng commented 9 years ago

@Gillou68310 ah i thought this was about glide64mk2, sorry, i have to test this on my n9 then, as rice doesn't work properly on my current device due to a graphics driver bug... does the green room bug happen even if Rotate=0?

Gillou68310 commented 9 years ago

yes ;-)

krnlyng commented 9 years ago

@Gillou68310 i see that the a button is not rotated properly in oot, i have to dig into the source to see what i can do about that, but i cannot reproduce the green room bug

Gillou68310 commented 9 years ago

I fixed the green room bug by setting the rotation_matrix in copyProgram (also set it in fillProgram just in case ;-) ) https://github.com/Gillou68310/mupen64plus-video-rice/commit/c3c17c82c424b89f60e8cd18ada62a82681d5433 The A button not being rotated bug is still here.

Narann commented 9 years ago

Thanks for reporting this.

@krnlyng Your rotate feature has been integrated to the old OGLESFragmentShader. Future Rice version will not have this but a unified OpenGL code path (both OGL and OGLES compliant).

Reading this ticket, I think it will be time for me to push my work in the official repo to avoid the old code to have feature that will be remove by my refactoring. All the work on OGLESFragmentShader will be lost as this should not be relevant anymore.

I will create a ticket to don't forget to integrate your modifications after the big commit. :)

I will "close" this ticket, not because the bug is not relevant but because I will have to fix this also after push.