search

mupen64plus / mupen64plus-video-rice

Video plugin for the Mupen64Plus v2.0 project, using OpenGL. This plugin is based on the RiceVideoLinux plugin from earlier versions of Mupen64Plus.
31 stars 40 forks source link

Integrate krnlyng rotate feature in the new combiner. #25

Closed Narann closed 9 years ago

Narann commented 9 years ago

Once Rice refactoring will be pushed in the main repo, I will have to integrate the rotate feature provided by @krnlyng. I will also have to check for a potential regression.

Narann commented 9 years ago

After some investigations to put @krnlyng work in Rice I realize the current design can't handle this nicely (I through about this but I just realize):

Only put the rotate in the combiner will only apply rotate on what is generated by the combiner, not RenderTexRect, DrawSimple2DTexture, DrawSimpleRect, DrawSpriteR_Render.

This generate the blue button regression @Gillou68310 posts:

zelda_rotate

I'm sad because I just finished the job but the current fixed pipeline design of Rice is incompatible with this and actually, put the rotation stuff in the Color Combiner is a bad idea. To do it nicely, we should rely on frame buffers, something Rice don't have yet.

I'm sorry @krnlyng but this is impossible for now without break everything. :(

I leave this ticket open as I consider using framebuffer in the future.