search

mupen64plus / mupen64plus-video-rice

Video plugin for the Mupen64Plus v2.0 project, using OpenGL. This plugin is based on the RiceVideoLinux plugin from earlier versions of Mupen64Plus.
31 stars 40 forks source link

Replace #include <SDL_opengles2.h> by #include "SDL_opengles2.h" #47

Closed Narann closed 9 years ago

Narann commented 9 years ago

@Nebuleon is pointing interesting compilation errors trying to compile on GCW Zero:

#include <SDL_opengles2.h> should be replaced by #include "SDL_opengles2.h"

Nebuleon commented 9 years ago

and other <> includes towards SDL, which are added to the "" include path by sdl2-config --cflags giving you an -I flag: https://forums.libsdl.org/viewtopic.php?t=5997

ghost commented 9 years ago

https://gcc.gnu.org/onlinedocs/cpp/Include-Syntax.html

include <file>

This variant is used for system header files. It searches for a file named file in a standard list of system directories. You can prepend directories to this list with the -I option (see Invocation). 

sdl2-config --cflags
-I/usr/include/SDL2 -D_REENTRANT

In contrast the -i option is for the " includes.It only falls back in GCC to the -I includes when nothing could be found in the local path or -i.

Narann commented 9 years ago

Mmmh after more investigation. I think #include <SDL_opengles2.h> is what we want: system header files. And as sdl2-config --cflags integrate the SDL2 folder we don't want the path.