search

mupen64plus / mupen64plus-video-rice

Video plugin for the Mupen64Plus v2.0 project, using OpenGL. This plugin is based on the RiceVideoLinux plugin from earlier versions of Mupen64Plus.
31 stars 40 forks source link

Unix Makefile: Discard unnecessary architecture checks #48

Closed Nebuleon closed 9 years ago

Nebuleon commented 9 years ago

For the benefit of #46.

Narann commented 9 years ago

Mmmh... after some investigations, we should maybe not remove everything. There is a lot of places where the Makefile try to avoid compilation problems on various architectures using those values.

What I suggest is to add the architecture you want to support here.

Nebuleon commented 9 years ago

Alright, so after building for MIPS with NO_ASM = 0, I see that there is indeed architecture-specific stuff, namely a CPUID instruction (and on MIPS, there is no such instruction); additionally, the code refers to eax, ecx and edx, which are Intel registers.

Gonna kill this pull request for now and remake it with a MIPS support stanza instead. That, or perhaps you want NO_ASM := 1 on all architectures other than Intel.