mupen64plus / mupen64plus-video-rice

Video plugin for the Mupen64Plus v2.0 project, using OpenGL. This plugin is based on the RiceVideoLinux plugin from earlier versions of Mupen64Plus.
31 stars 40 forks source link

build: Unable to build on aarch64 #85

Closed pgwipeout closed 4 years ago

pgwipeout commented 4 years ago

aarch64 is not supported. Building on aarch64 produces the following error: Makefile:125: *** CPU type "aarch64" not supported. Please file bug report at 'https://github.com/mupen64plus/mupen64plus-core/issues'. Stop.

enigma9o7 commented 4 years ago

Same. I tried from 2.5.9 source pack. I had to remove rice from the install script so it would move on to glide and complete...

haydenmc commented 4 years ago

I was able to just copy paste the makefile section enabling aarch64 support across from another project. After that, it built just fine and seems to run okay.

After projects/unix/Makefile@123:

ifneq ("$(filter aarch64,$(HOST_CPU))","")
    CPU := AARCH
    ARCH_DETECTED := 64BITS
    PIC ?= 1
    NEW_DYNAREC := 1
    NO_ASM := 1
    NO_SSE := 1
endif
Narann commented 4 years ago

Thanks.

NEW_DYNAREC and NO_SSE are not supposed to do anything.

ifneq ("$(filter aarch64,$(HOST_CPU))","")
    CPU := AARCH
    ARCH_DETECTED := 64BITS
    PIC ?= 1
    NO_ASM := 1
endif

If anyone confirm this works, I will add this to the repo.

pgwipeout commented 4 years ago

Good Afternoon,

I can confirm that fixes the issue @Narann. Built without issue native on the Jetson Nano aarch64 board.

Narann commented 4 years ago

Modifications have been merged to master. Closing this ticket. Feel free to reopen or open a new one if you have problems.