muppet3000 / homeassistant-growatt_server_api

Home Assistant Integration for Growatt - Upstream repo for the growatt_server integration that is part of the Core Home Assistant repository
MIT License
52 stars 6 forks source link

ENHANCEMENT - AC Couple systems are not supported #13

Open muppet3000 opened 1 year ago

muppet3000 commented 1 year ago

Describe the bug See: https://github.com/home-assistant/core/issues/78149

Growatt Device Type

Device(s): AC Couple / SPA****

Home Assistant information

Additional context

This bug has been duplicated from the original in the Home Assistant Core repo and will be fixed here before before being merged up-stream. Everyone that has contributed to the bugs so far has been tagged in the comments so that they can receive updates from this repo.

muppet3000 commented 1 year ago

Hi All, sorry for the mass-tagging but I wanted you all to know about the new ticket that I've raised in this repo for adding support for the AC Couple type of inverter to the integration. As you're hopefully all aware I've moved the plugin out of Core and will primarily maintain it here because it's much easier and quicker to develop. When there are significant releases I will merge the changes up-stream into Home Assistant Core, but that will be much slower.

Now for the tags...... @riffy99 @jolaca01 @wurliwax @Benchamoneh @coleburg @davelegg83

NOTE - I currently don't have ANY credentials for an AC Couple/SPA inverter. If anyone is willing to give me access to their system so that I can implement this functionality I would be really grateful. There is an FAQ on how to do this 'safely' here

muppet3000 commented 1 year ago

@gshoebridge - I think this ticket may be relevant to the issue you posted here: https://github.com/home-assistant/core/issues/81737 Because your ticket was never logged against the integration correctly in HA Core you've missed out on the various discussions & changes I've been planning. I recommend catching up here: https://community.home-assistant.io/t/growatt-integration-roadmap/510221, specifically the following posts: https://community.home-assistant.io/t/growatt-integration-roadmap/510221?u=muppet3000 https://community.home-assistant.io/t/growatt-integration-roadmap/510221/8?u=muppet3000

Benchamoneh commented 1 year ago

@muppet3000 I've just sent you credentials for my device type (AC Couple). Let me know if you need anything else.

muppet3000 commented 1 year ago

@muppet3000 I've just sent you credentials for my device type (AC Couple). Let me know if you need anything else.

Thanks I've received them and tested them. They'll be held securely until I get on to implementing this.

gshoebridge commented 1 year ago

Thank you

Really grateful for the follow up mail and information

Great to see the progress too.

I have done the software side no just need to agree which of the 55 sensors should map into what section of the energy dashboard.

Now it is HACS I can track the changes and improvements.

If there’s anyway my current config can help please let me know (access to the configuration I have etc)

Kind regards

Guy Shoebridge

Sent from my iPhone

On 24 Jan 2023, at 22:05, Chris Straffon @.***> wrote:



@muppet3000https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmuppet3000&data=05%7C01%7C%7Cc348b5aa450f4ba6018408dafe5726ae%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638101947513499014%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=mFz8Zo5Zousr2lVl%2BnAWYooXKXCoLO8jPG0s9x0HPVU%3D&reserved=0 I've just sent you credentials for my device type (AC Couple). Let me know if you need anything else.

Thanks I've received them and tested them. They'll be held securely until I get on to implementing this.

— Reply to this email directly, view it on GitHubhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmuppet3000%2Fhomeassistant-growatt_server_api%2Fissues%2F13%23issuecomment-1402753433&data=05%7C01%7C%7Cc348b5aa450f4ba6018408dafe5726ae%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638101947513499014%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=O5A9iswEsvCxa1h%2FoUYMSzLaQDafVtazfF8U1h95cRY%3D&reserved=0, or unsubscribehttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAISWBJTS6I4XUB5EFFI35FLWUBG3ZANCNFSM6AAAAAAUFS57EE&data=05%7C01%7C%7Cc348b5aa450f4ba6018408dafe5726ae%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638101947513499014%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=12Iqi2MuBNLMPOp1EstDZNv2k162fSrvJUuXMVag%2BUg%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>

coleburg commented 1 year ago

Hi All, sorry for the mass-tagging but I wanted you all to know about the new ticket that I've raised in this repo for adding support for the AC Couple type of inverter to the integration. As you're hopefully all aware I've moved the plugin out of Core and will primarily maintain it here because it's much easier and quicker to develop. When there are significant releases I will merge the changes up-stream into Home Assistant Core, but that will be much slower.

Now for the tags...... @riffy99 @jolaca01 @wurliwax @Benchamoneh @coleburg @davelegg83

NOTE - I currently don't have ANY credentials for an AC Couple/SPA inverter. If anyone is willing to give me access to their system so that I can implement this functionality I would be really grateful. There is an FAQ on how to do this 'safely' here

Not sure if you had spotted this, but I also discovered the API details required for AC Coupled, I posted here if it helps

https://github.com/Sjord/growatt_api_client/issues/33

there is also type of 'spa_ac_discharge_time_period' and I also use curl -request POST -i -b cookies.txt -d "op=spaSetApi&param1=00&param2=01&param3=23&param4=59&param5=1&param6=00&param7=00&param8=00&param9=00&param10=0&param11=00&param12=00&param13=00&param14=00&param15=0&serialNum={serial}type=spa_load_flast" https://server-api.growatt.com/newTcpsetAPI.do

Let me know if you need anything else, I can provide the JSON thats returned if that helps too.

muppet3000 commented 1 year ago

etails required for AC Coupled, I posted here if it helps

Thanks - I'll take a look at that PR, no need to send extra info, I've got everything I need :)

muppet3000 commented 1 year ago

Thank you Really grateful for the follow up mail and information Great to see the progress too. I have done the software side no just need to agree which of the 55 sensors should map into what section of the energy dashboard. Now it is HACS I can track the changes and improvements. If there’s anyway my current config can help please let me know (access to the configuration I have etc) Kind regards Guy Shoebridge Sent from my iPhone On 24 Jan 2023, at 22:05, Chris Straffon @.> wrote:  @muppet3000https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmuppet3000&data=05%7C01%7C%7Cc348b5aa450f4ba6018408dafe5726ae%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638101947513499014%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=mFz8Zo5Zousr2lVl%2BnAWYooXKXCoLO8jPG0s9x0HPVU%3D&reserved=0 I've just sent you credentials for my device type (AC Couple). Let me know if you need anything else. Thanks I've received them and tested them. They'll be held securely until I get on to implementing this. — Reply to this email directly, view it on GitHubhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmuppet3000%2Fhomeassistant-growatt_server_api%2Fissues%2F13%23issuecomment-1402753433&data=05%7C01%7C%7Cc348b5aa450f4ba6018408dafe5726ae%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638101947513499014%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=O5A9iswEsvCxa1h%2FoUYMSzLaQDafVtazfF8U1h95cRY%3D&reserved=0, or unsubscribehttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAISWBJTS6I4XUB5EFFI35FLWUBG3ZANCNFSM6AAAAAAUFS57EE&data=05%7C01%7C%7Cc348b5aa450f4ba6018408dafe5726ae%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638101947513499014%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=12Iqi2MuBNLMPOp1EstDZNv2k162fSrvJUuXMVag%2BUg%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.>

No problem - Would it be helpful I could put an 'FAQ' together on what values should be used on the energy dashboard page?

muppet3000 commented 1 year ago

Given the fact that the Growatt API is increasingly unreliable (see #15) I have slowly winding down support for this repo and instead directing people towards trying Grott instead: https://github.com/muppet3000/homeassistant-grott

I'm happy to help people out migrating over to the new method, it's far more reliable and I'm focussing all my efforts into making it the best possible option for everyone (including feeding back changes to the main developer)