muqa-org / demo

Municipal Quadratic Funding Initiative
https://zazelenimo.com
MIT License
2 stars 1 forks source link

create a wallet for each user #2

Open tomislavmamic opened 3 months ago

tomislavmamic commented 3 months ago

When a user creates an in-app account, they also get and Ethereum account and a wallet to interact with it. User can't use external wallet. User can't use wallet for anything else than what is intended within the app.

Feature: Wallet
  As a user
  I want to have a wallet
  Because I want to hold currency and make transactions

  Scenario: User sees his token balance
    Given I'm not logged in
    When I open start page
    Then I can see my token balance
b0rza commented 3 months ago

@tomislavmamic why can't they use an external wallet?

tomislavmamic commented 3 months ago

@tomislavmamic why can't they use an external wallet?

Multiple reasons:

  1. For now, this will help us decrease the complexity, and simplify the UI for the user
  2. We are targeting new users with this project, existing crypto users aren't our focus, but they can transfer funds from their existing wallet if they want to use this app, this will be only a small nuisance for them
  3. Most of existing crypto users probably wouldn't want to have a KYC on their existing wallet for a one off donation
  4. With Connect we can actually control what a user can do. Although the wallet is non-custodial, if I understood correctly, we can prevent user from accessing the wallet if we want. This is useful in cases of scam/fraud attempts.
b0rza commented 3 months ago

Makes sense, I was thinking about knowledgeable users. But if they are not a focus for v1 or this at all, I agree it's not needed.

kkatusic commented 3 months ago

@tomislavmamic if we use cometh.io wallet option, they can connect to app using existing wallet, for example MetaMask or we will disable that?

tomislavmamic commented 3 months ago

I suggest we disable that for now.

Tomislav Mamić

On Wed, 3 Jul 2024 at 18:19, kkatusic @.***> wrote:

@tomislavmamic https://github.com/tomislavmamic if we use cometh.io wallet option, they can connect to app using existing wallet, for example MetaMask or we will disable that?

— Reply to this email directly, view it on GitHub https://github.com/tomislavmamic/muqa/issues/2#issuecomment-2206736141, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADZV5K23JVJHCJDF66MGSNDZKQQALAVCNFSM6AAAAABJFZ5EAGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBWG4ZTMMJUGE . You are receiving this because you were mentioned.Message ID: @.***>

kkatusic commented 3 months ago

Ok