search

muqeet-khan / BlazorComponents

Simple reusable Blazor component library
50 stars 9 forks source link

Add pie chart #14

Closed tenickl closed 6 years ago

tenickl commented 6 years ago

Hi, my first pull request, sorry if I missed some etiquette. I would like to use the pie chart in my blazor test application so i figured why not create a pull request for that.

muqeet-khan commented 6 years ago

@tenickl Thank You for the PR!

I usually maintain releases with Blazor version updates. I will take a look and merge this soon if it all fits well (I have a few changes in another PR that may effect this). Appreciate your contribution.

tenickl commented 6 years ago

Thanks, if I can improve something please don't hesitate to mention it.

muqeet-khan commented 6 years ago

@tenickl I appreciate your contribution and apologize for not merging this change. After making the required changes on master, my lack of git knowledge won and I couldn't figure out how to include your changes in the "updated" master. You would probably have needed to rebase, I think. I have added pie chart based on your implementation from my end and made sure to add you to the credits for this release. Hope you don't mind. Thank you again for contributing.