muralikg / puppetcam

Export puppeteer tab as webm video
MIT License
322 stars 63 forks source link

Black strips on top and bottom in video, while using "executablePath" of newest version of chrome (84). #23

Open shubham-pixelnx opened 4 years ago

shubham-pixelnx commented 4 years ago

Trying to get 4k output, just added executablePath but in the output video it's showing the black border at the top and bottom of the video, check this screenshot below. out Using Node v12.18.0, and puppeteer-core@5.2.1 also I noticed this bar not sure if this is the problem Untitled

Here's the modified code, else everything is same.

const puppeteer = require("puppeteer-core");
let width = 3840;
let height = 2160;
let options = {
    headless: false,
    executablePath:
        "C:\\Program Files (x86)\\Google\\Chrome\\Application\\Chrome.exe",
    args: [
        "--enable-usermedia-screen-capturing",
        "--allow-http-screen-capture",
        "--auto-select-desktop-capture-source=puppetcam",
        "--load-extension=" + __dirname,
        "--disable-extensions-except=" + __dirname,
        "--disable-infobars",
        `--window-size=${width},${height}`,
    ],
};
JamesBotterill commented 3 years ago

I believed I resolved this by adding —kiosk to my args

shubham-pixelnx commented 3 years ago

Okay, will try. Thanks, James!