muralikg / puppetcam

Export puppeteer tab as webm video
MIT License
322 stars 62 forks source link

should audio recording work? #4

Closed brandonmp closed 5 years ago

brandonmp commented 6 years ago

Thanks for putting this together.

I'm trying to record video w/ audio. Out of the box this doesn't seem to work (on Ubuntu)--is it something you've looked into?

muralikg commented 6 years ago

I did not need the audio for my case. You can try setting audio to true in background.js and see if that helps.

brandonmp commented 6 years ago

yeah I gave that a shot. it doesn't fail outright, but the program doesn't stop after the timeout when audio: true.

thanks for the quick response--will keep at it & update for posterity if I find something

bitk0der commented 5 years ago

Audio recording works well, insted audio: true you should use:

audio: {
                  mandatory: {
                      chromeMediaSource: 'system'
                  }
}
muralikg commented 5 years ago

@brandonmp, I have tested @bitk0der 's solution and it works well. Feel free to open the issue if needed.

FisherRobison commented 5 years ago

Any ideas on getting audio to work in docker? This fork (https://github.com/pzagor2/puppetcam) works awesome for docker but having issues with audio. @pzagor2

pzagor2 commented 5 years ago

@FisherRobison I haven't spend any time trying to get the audio to work.

muralikg commented 5 years ago

@FisherRobison Have you tried this? Looks like you need to map some devices from host machine to the container

zakcali commented 4 years ago

Audio recording works well, insted audio: true you should use:

audio: {
                  mandatory: {
                      chromeMediaSource: 'system'
                  }
}

Unfortunately, audio is not recording in Windows 10. I could only able to full screen (not chrome tab) capture with audio included in Windows 10. Reference: https://www.electronjs.org/docs/api/desktop-capturer