search

murarth / ketos

Lisp dialect scripting and extension language for Rust programs
Apache License 2.0
751 stars 45 forks source link

Warnings from static analysis with clippy #38

Closed alienscience closed 5 years ago

alienscience commented 6 years ago

Hello, I have been reading through the Ketos code which has been a great learning experience -- thanks.

I noticed that the Rust static analyser called "clippy" is now available on Rust stable:

rustup component add clippy-preview

More information on installing is given in the github repository.

I ran clippy on the Ketos code and it made lots of suggestions that I would mostly consider to be useful. I have attached the report clippy.log

Would you be open to people making PRs to make the changes suggested by clippy? Or do you think that the changes suggested by clippy are not helpful?

murarth commented 6 years ago

I looked over the clippy warnings and fixed a few non-trivial issues myself.

I would be happy to accept a PR that addresses the remaining warnings.

ysimonson commented 5 years ago

Almost all of these are addressed at this point; there's just a couple of linters that are ignored, and one that doesn't have a fix because of borrow checker constraints.