search

murat-dogan / node-datachannel

WebRTC For Node.js and Electron. libdatachannel node bindings.
Mozilla Public License 2.0
292 stars 56 forks source link

fix: make rollup a dev dependency #251

Closed ThaUnknown closed 4 months ago

ThaUnknown commented 4 months ago

fixes #250

the current version of rollup requires node 18, while the library uses node 16, since its a required dependency, not a dev dependency, it either needs to be downgraded, or moved to dev dependencies as it errors when installing the package with node16

murat-dogan commented 4 months ago

Thanks. It is also a good idea to drop support for node 16 soon.

ThaUnknown commented 4 months ago

Thanks. It is also a good idea to drop support for node 16 soon.

it would be preferable if you didn't if there's no need, from what I saw, there's nothing forcing you to drop node16

ThaUnknown commented 4 months ago

@murat-dogan could we get this deployed as 0.9.1?