search

murat-dogan / node-datachannel

WebRTC For Node.js and Electron. libdatachannel node bindings.
Mozilla Public License 2.0
292 stars 56 forks source link

feat: support setting ICE ufrag and pwd, disabling fingerprint validation and specifying certificates #256

Open achingbrain opened 4 months ago

achingbrain commented 4 months ago

https://github.com/paullouisageneau/libjuice/pull/243 allows setting the ICE ufrag and pwd fields instead of generating random ones every time.

https://github.com/paullouisageneau/libdatachannel/pull/1207 adds an init arg to setLocalDescription to allow setting the fields in libjuice from libdatachannel.

https://github.com/paullouisageneau/libdatachannel/pull/1206 allows reading the fingerprint of the cert being used by the remote peer.

This PR adds the init arg to setLocalDescription, and the remoteFingerprint method, plus the missing config keys.

This is required to implement libp2p WebRTC-Direct.

It will require the PRs above being merged and shipped before this is ready so I've opened it as a draft for now.

Refs: https://github.com/paullouisageneau/libdatachannel/issues/1166

murat-dogan commented 3 months ago

Thanks for the PR. It would be good if you also add these changes here;

murat-dogan commented 3 months ago

Hello, Thanks for the work!

When that could be ready for merging?