search

murat-dogan / node-datachannel

WebRTC For Node.js and Electron. libdatachannel node bindings.
Mozilla Public License 2.0
308 stars 60 forks source link

Fix missing GXX env variable in build #291

Closed leblowl closed 2 months ago

leblowl commented 2 months ago

In https://github.com/murat-dogan/node-datachannel/pull/282, I forgot to add the GXX environment variable to the actual compilation step

murat-dogan commented 2 months ago

Thanks

funniray commented 2 months ago

@murat-dogan and @leblowl I also completely forgot to mention that you have to define the allowed environment variables in the sudo command here https://github.com/murat-dogan/node-datachannel/blob/master/.github/workflows/build-linux.yml#L94

murat-dogan commented 2 months ago

No problem. I didn't see it also. Addıng now.

murat-dogan commented 2 months ago

Compiled successfully. Thanks @funniray

leblowl commented 2 months ago

Thanks @funniray, good catch!