search

murat-dogan / node-datachannel

WebRTC For Node.js and Electron. libdatachannel node bindings.
Mozilla Public License 2.0
308 stars 60 forks source link

Fix local description sdp type #302

Closed pimterry closed 2 weeks ago

pimterry commented 2 weeks ago

I think the type here isn't quite right - the type will be the SDP type (offer/answer/pranswer/rollback) represented by both RTCSdpType and DescriptionType, while the sdp field is the actual SDP description string, just as in remoteDescription. Resulted in some strange types in my logic that looks at this downstream!

pimterry commented 2 weeks ago

Don't think the linting error here is related to this change, but let me know if there's something I'm missing there.

murat-dogan commented 2 weeks ago

Thanks