Album art fails if Artist or Album contains uppercase non-ascii characters

[GoogleCodeExporter]

What steps will reproduce the problem?
1. XBMC Music Library contains artist or album with uppercase Danish 
characters (Æ Ø Å)
2. Open Music view in remote app.

What is the expected output? What do you see instead?

I expect covers to be loaded, aforementioned albums do not get their 
covers.

What version of the product are you using? On what operating system?
Latest and greatest svn on HTC Magic

This is actually not a defect in the remote app. The cause is that XBMC 
itself does not correctly lowercase the international charactes before 
crc32'ing them. I did some testing with the XBMC code and found that only 
ascii characters are properly lower-cased.

I've attached a patch that cirmumvents this XBMC-"feature".
It adds a couple of public methods (computeLower and computeAsHexLower) and 
a private method (toXBMCLowerCase) to Crc32.java.
It also changes Album.java and Artist.java to make use of the computeLower 
method in stead of lowercasing the strings before calling Crc32.compute().
Actually, it makes the interface to Crc32 even more XBMC-ish, since the 
added methods are used in the XBMC code.

:O) Mikkle

Original issue reported on code.google.com by mukkenb...@gmail.com on 14 Oct 2009 at 11:29

[GoogleCodeExporter]

Original comment by mukkenb...@gmail.com on 14 Oct 2009 at 11:30

Attachments:

• android-xbmc-remote-issue35-crc32-lowercase-i18n.diff

[GoogleCodeExporter]

Cool! Will check it out later.

Original comment by phree...@gmail.com on 15 Oct 2009 at 7:24

• Changed state: Accepted

[GoogleCodeExporter]

This issue was closed by revision r210.

Original comment by phree...@gmail.com on 15 Oct 2009 at 11:06

• Changed state: Fixed

[GoogleCodeExporter]

Couldn't test it because I have no albums named accordingly, but it compiles 
and the 
code looks good.

Original comment by phree...@gmail.com on 15 Oct 2009 at 11:07