search

murataya / o2popper

MIT License
10 stars 2 forks source link

Support for multiple email accounts #3

Closed TalAloni closed 2 years ago

TalAloni commented 2 years ago

Hi, Reviewing the code it seems there is some sort of support for multiple email accounts (e.g. this) However, there seem to be this logic in place to override the username detection mechanism.

I would expect that we would explicitly set the username only if it was not provided, and would appreciate if you could explain whether we can / should improve this logic to improve usability when a single o2popper instance is serving multiple users using the same client_id / secret. (we want to avoid an accidental override of the username)

Thanks!

murataya commented 2 years ago

I haven't documented it because of insufficient support for multiple accounts.

If you do not specify the username, it will work with multiple accounts. However, they must have the same client_id / secret.

I'm currently working on a refurbishment to support multiple accounts.

My development is slow and you may not be able to wait. I'm sorry.

TalAloni commented 2 years ago

It works well for my purposes - thanks!