search

muratcorlu / ngx-script-loader

Angular 3rd party script loader
MIT License
33 stars 6 forks source link

Upgrade peer dependencies from Angular 6 to 7 #11

Closed rafa-suagu closed 5 years ago

rafa-suagu commented 5 years ago

Upgrade peer Angular dependencies to avoid the following warnings:

warning ngx-script-loader@1.0.0" has incorrect peer dependency "@angular/common@^6.0.0-rc.0 || ^6.0.0".
warning ngx-script-loader@1.0.0" has incorrect peer dependency "@angular/core@^6.0.0-rc.0 || ^6.0.0".
rafa-suagu commented 5 years ago

If you accept PR I can do it quickly.

muratcorlu commented 5 years ago

Sure. PRs are very welcome.

muratcorlu commented 5 years ago

But I didn't check library at v7 yet. Can you also check if it's working properly? I don't expect any problem but we need to check anyway

rafa-suagu commented 5 years ago

Yes for sure, we are using with Angular 7 + SSR without any problem :)

muratcorlu commented 5 years ago

Merged. Thank you. I'll create a release with that. I think a minor version will be enough, right?

rafa-suagu commented 5 years ago

Yes, totally agree.

muratcorlu commented 5 years ago

Release as 1.1.0 https://www.npmjs.com/package/ngx-script-loader

rafa-suagu commented 5 years ago

Thank you @muratcorlu