search

muratcorlu / ngx-script-loader

Angular 3rd party script loader
MIT License
33 stars 6 forks source link

Angular8 support #16

Closed bartholomej closed 5 years ago

bartholomej commented 5 years ago

Support for Angular8 (fix #15) and fix this annoying warning:

> ngx-script-loader@1.1.0" has incorrect peer dependency "@angular/common@^6.0.0 || ^7.0.0".

Tested: ✓ Your built-in tests passed succefully ✓ Tested with your demo application in ng7 and ng8 ✓ Used with ng8 in production app for more than a month

muratcorlu commented 5 years ago

Hey, thanks for your contribution. Somehow CI is broken now. I'll try to check it.

bartholomej commented 5 years ago

Hi, yes it's broken but I believe there is only something wrong in docker image because it fails on apt install google-chrome-stable.

bartholomej commented 5 years ago

So, what do you think? Any news? ;) @muratcorlu

muratcorlu commented 5 years ago

I think I fixed the CI issue. Can you merge latest master and push again?

bartholomej commented 5 years ago

Great ;) It works! @muratcorlu

muratcorlu commented 5 years ago

Merged and released as v1.2.0 https://www.npmjs.com/package/ngx-script-loader

Thanks @bartholomej 👍

bartholomej commented 5 years ago

🤘