search

muratgozel / MIMEText

RFC-2822, RFC-2045 and RFC-2049 compliant raw email message generator.
https://muratgozel.github.io/MIMEText/
MIT License
82 stars 35 forks source link

Mailbox function signature changes in patch release? #65

Closed PodStuart closed 8 months ago

PodStuart commented 8 months ago

I can see from the issue history there have been some typing issues beyond 3.0.16. I was seeing issues similar to others from 3.0.17 to 3.0.20 but these have been resolved in 3.0.21 but replaced by another problem.

Mailbox.getRecipients() used to return Mailbox | Mailbox[] | undefined.

It now returns string | Mailbox | undefined.

Mailbox.getSender() used to return Mailbox | undefined

It now returns string | Mailbox | undefined.

These changes are causing TypeScript errors in our builds.

Node version 20.11.0. Nx version 18.0.4. Typescript version 5.3.3.

Happy to provide any further information required.

muratgozel commented 8 months ago

probably my mistake during rewriting the typings, will check this shortly

muratgozel commented 8 months ago

@PodStuart hi again, i did corrections on few definitions including getRecipients and getSender:

PodStuart commented 8 months ago

Thanks for sorting that.