search

muratgozel / node-calver

Calendar based software versioning library as node.js module and with cli support. 📅
MIT License
29 stars 5 forks source link

Treat pre-release as minor to their unsuffixed version #22

Closed imgrant closed 6 months ago

imgrant commented 1 year ago

This is a suggested solution for issue #21 — where a semantic tag is incorrectly incremented when incrementing a modifier tag, and also when dropping a modifier tag. The example in the issue is for a format of YYYY.MM.MINOR.

Essentially, it treats, e.g. 2023.6.0 as later than pre-releases such as 2023.6.0-rc.0. Some tests are included.

Fixes #21

imgrant commented 1 year ago

@muratgozel Would love to know whether you think this PR is correct/desirable/viable. I appreciate it does change the behaviour of node-calver.

I am using my fork of this locally, but it complicates things because although I think this is the right place to implement this, I'm actually really using another package which has this as its dependency. So I have to also use a fork of that package, so that I could alter its dependencies to use my fork of this package. Obviously, I'd rather not have the debt of carrying forks forward.

muratgozel commented 6 months ago

@imgrant sorry for the late reply, im merging this pr but will also update the library to its next major version as there are things in this lib that doesn't fit to the calendar versioning scheme. thank you for the fixes. 🙏

imgrant commented 6 months ago

Hey @muratgozel many thanks, glad to see this project is still alive! I can also rebase my changes in #23 shortly

muratgozel commented 6 months ago

@imgrant no need to rebase or anything in #23 it isn't important regarding the next major release. if i may ask, do you still use calver in production? and what kind of project if so?

imgrant commented 6 months ago

I see. Yes, I use node-calver in production (a micro services web site, Calver is used in the CICD pipeline because we preferred it over semantic), although I use my own fork because I need the functionality in this PR and #23. Be great if #23 was merged and then I could go back to using this upstream instead of maintaining a fork.

I'm using it with release-it! See eg: https://github.com/casmith/release-it-calver-plugin/issues/28

muratgozel commented 6 months ago

I will merge the #23 but won't release it, you can use it by npm i github/... once i done that. I would like to have your opinions @imgrant on the next release, its a bit BREAKING, happy to see people actually using calver in their pipelines. i'm using it in my monorepo versioning too.

imgrant commented 6 months ago

I will merge the #23 but won't release it, you can use it by npm i github/... once i done that. I would like to have your opinions @imgrant on the next release, its a bit BREAKING, happy to see people actually using calver in their pipelines. i'm using it in my monorepo versioning too.

Super thanks! Happy to review a PR or whatever on the next release, thanks for the heads-up.

muratgozel commented 6 months ago

hey @imgrant updates were made