Solve some issues - Githubissues

muratgozel / node-calver

Calendar based software versioning library as node.js module and with cli support. 📅

MIT License

28 stars 5 forks source link

Solve some issues #4

Closed aazbeltran closed 3 years ago

aazbeltran commented 3 years ago

General

Features

Add parameter to preserve the current date (42d2455479c00db35c218e48b8feca258fe106b0)

Bug Fixes

Solve issue with timezones (c19000542e04147957208f111dc7992304af114f)
- new Date('2020-01-01') identify 2019-12-31 on GMT-6 due to timezone
Solve issue with lower tags resetting to zero (e9652977336222a4a770d3c41149523754c2b052)
Solve issue issue when specify an semantictag and the date is changed (d619c8a82528afe5a0e9f9018c4d0351485195d8)

Code Refactoring

Remove unused breaks (999a0085d25e721d4defd11a6eb00ab8d07ffb18)
Make more flexible the #2 issue solution (18af6b9a6e4ca7fc36fe9341de1582f71deb5b8c)
Invert preserverdate functionality to updatedate (f53545cfd600763558465e69a2821bb50e84709f)

Internal Workflow

Add jasmine package to dev dependencies (3d82dfd718fa876cb185ea3c7c67c6fde5187838)

Closes: #3

muratgozel commented 3 years ago

Thanks, a lot of updates here. There is just one problem. As I have mentioned in the issue, calver should preserve the date portion unless no argument given to the .inc(). If you want to update both date and semantic tags then you should .inc() first and then .inc('minor'). Date tags are the major of semantic tags. Can you please remove your preserveDate logic? Or you may replace it with something like breakDate.

aazbeltran commented 3 years ago

Could you double-check, please?

muratgozel commented 3 years ago

thank you. merging now and i will do in-depth review later.