search

muratguzel / letsrate

The best way to add rating capabilities to your rails application and your activerecord models.
http://letsrate.herokuapp.com
198 stars 234 forks source link

Refactor letsrate model to fix rating on inherited models #60

Open 3den opened 10 years ago

3den commented 10 years ago

This PR is need to fix a problem on on the rating cache that was saving the wrong cacheable_type for models. I also cleaned up the code to make it easier to understand. Please merge this for the next version.

3den commented 10 years ago

@muratguzel please merge this PR so I can use the oficial version. Thanks for publishing this gem I really liked it.

3den commented 10 years ago

@muratguzel btw why do you use travis if you have no tests?

muratguzel commented 10 years ago

I will add tests :) But yes you are right. And also I will check and merge you commit. Thanks

3den commented 10 years ago

Thanks @muratguzel :)

berkos commented 10 years ago

hi all! i was wondering, is this still valid for merging?